Re: Add some autoconf warnings
Francois Gouget <fgouget(a)free.fr> writes:
I thought I had sent this patch months ago but apparently not. The idea is to warn the user when some often used libraries are missing and is based on the warnings issued for bad Mesa or X configurations. Let me know if the range of checks should be expanded or reduced or otherwise tweaked.
We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason. -- Alexandre Julliard julliard(a)winehq.org
On Fri, 18 Mar 2005, Alexandre Julliard wrote:
Francois Gouget <fgouget(a)free.fr> writes:
I thought I had sent this patch months ago but apparently not. The idea is to warn the user when some often used libraries are missing and is based on the warnings issued for bad Mesa or X configurations. Let me know if the range of checks should be expanded or reduced or otherwise tweaked.
We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason.
Ok. My recollection was that we should not indiscriminately warn about missing libraries which is why I targeted just some of them. Ok, maybe ICU should not have been on the list (certainly Shachar would disagree<g>), but a system that has a non-functional OSS or Alsa driver probably won't have sound which I see as a significant limitation, especially with all the gaming development we see these days. Maybe a check that there is at least one functional sound system would be ok? if test "$ac_cv_c_opensoundsystem" = "no" -a -z "$ALSALIBS" -a \ -z "$ARTSC_LIBS" -a -z "$NASLIBS" -a -z "$AUDIOIOLIBS" then echo "*** No sound system was found. Windows applications will be silent." fi But I personally don't mind checking the configure log so I don't care much one way or another. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
I had sent in a patch similar to this a while back. I still think it is very useful to warn at least about OpenGL, I recall having to help a lot of people try to debug issues with not having that support. Given the huge amount of output from configure I think it would make sense to print out what was and wasn't supported as far as modules. The handful of extra lines would save people from being confused about whether support was or wasn't built in. Other projects print this data out at the end of a configure run and I've found it quite useful. Chris On Fri, 18 Mar 2005 15:44:10 +0100 (CET), Francois Gouget <fgouget(a)free.fr> wrote:
On Fri, 18 Mar 2005, Alexandre Julliard wrote:
Francois Gouget <fgouget(a)free.fr> writes:
I thought I had sent this patch months ago but apparently not. The idea is to warn the user when some often used libraries are missing and is based on the warnings issued for bad Mesa or X configurations. Let me know if the range of checks should be expanded or reduced or otherwise tweaked.
We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason.
Ok. My recollection was that we should not indiscriminately warn about missing libraries which is why I targeted just some of them. Ok, maybe ICU should not have been on the list (certainly Shachar would disagree<g>), but a system that has a non-functional OSS or Alsa driver probably won't have sound which I see as a significant limitation, especially with all the gaming development we see these days.
Maybe a check that there is at least one functional sound system would be ok?
if test "$ac_cv_c_opensoundsystem" = "no" -a -z "$ALSALIBS" -a \ -z "$ARTSC_LIBS" -a -z "$NASLIBS" -a -z "$AUDIOIOLIBS" then echo "*** No sound system was found. Windows applications will be silent." fi
But I personally don't mind checking the configure log so I don't care much one way or another.
-- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
Chris Morgan wrote:
Given the huge amount of output from configure I think it would make sense to print out what was and wasn't supported as far as modules. The handful of extra lines would save people from being confused about whether support was or wasn't built in. Other projects print this data out at the end of a configure run and I've found it quite useful.
I agree. It would be a nice feature. -- Anssi Hannula
Hi, On Fri, Mar 18, 2005 at 07:01:21PM +0200, Anssi Hannula wrote:
Chris Morgan wrote:
Given the huge amount of output from configure I think it would make sense to print out what was and wasn't supported as far as modules. The handful of extra lines would save people from being confused about whether support was or wasn't built in. Other projects print this data out at the end of a configure run and I've found it quite useful.
I agree. It would be a nice feature. Same here. I think it's much better than not printing it.
If confusion is of a concern (i.e. people are reacting in strange ways to these messages), then you could always add a phrase like "For further explanations, please read http://www.winehq.org/somepage" at the end in case we print an alerting message after having found some troublesome setup. Andreas Mohr
Francois Gouget <fgouget(a)free.fr> writes:
Maybe a check that there is at least one functional sound system would be ok?
if test "$ac_cv_c_opensoundsystem" = "no" -a -z "$ALSALIBS" -a \ -z "$ARTSC_LIBS" -a -z "$NASLIBS" -a -z "$AUDIOIOLIBS" then echo "*** No sound system was found. Windows applications will be silent." fi
Yes, something like that would be acceptable. -- Alexandre Julliard julliard(a)winehq.org
participants (5)
-
Alexandre Julliard -
Andreas Mohr -
Anssi Hannula -
Chris Morgan -
Francois Gouget