Re: [PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.

[Alexandre Julliard]

Robert Shearman <rob(a)codeweavers.com> writes:
> Use an attribute to store the const qualifier for the pointer and type.
>
> Allow multiple type-qualifiers to be applied to a type by adding a
> declaration-specifier rule that encompasses type-qualifiers and types.

This seems to drop the const in some cases, for instance:

--- include/propidl.h.old	2008-04-28 13:52:01.000000000 +0200
+++ include/propidl.h	2008-04-28 13:52:11.000000000 +0200
@@ -332,7 +332,7 @@
     virtual HRESULT STDMETHODCALLTYPE WritePropertyNames(
         ULONG cpropid,
         const PROPID rgpropid[],
-        const LPOLESTR rglpwstrName[]) = 0;
+        LPOLESTR rglpwstrName[]) = 0;
 
     virtual HRESULT STDMETHODCALLTYPE DeletePropertyNames(
         ULONG cpropid,

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.

[Robert Shearman]

Alexandre Julliard wrote:
> Robert Shearman <rob(a)codeweavers.com> writes:
> > Use an attribute to store the const qualifier for the pointer and type.
> >
> > Allow multiple type-qualifiers to be applied to a type by adding a
> > declaration-specifier rule that encompasses type-qualifiers and types.
>
> This seems to drop the const in some cases, for instance:
>
> --- include/propidl.h.old	2008-04-28 13:52:01.000000000 +0200
> +++ include/propidl.h	2008-04-28 13:52:11.000000000 +0200
> @@ -332,7 +332,7 @@
>      virtual HRESULT STDMETHODCALLTYPE WritePropertyNames(
>          ULONG cpropid,
>          const PROPID rgpropid[],
> -        const LPOLESTR rglpwstrName[]) = 0;
> +        LPOLESTR rglpwstrName[]) = 0;
>
> virtual HRESULT STDMETHODCALLTYPE DeletePropertyNames(
>          ULONG cpropid,

Ok, I'll have to investigate why this is happening. Thanks for spotting it.

-- 
Rob Shearman