Re: [PATCH 2/4] ddraw: Send device2_Draw* through device3_Draw*

[Henri Verbeet]

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> -    return IDirect3DDevice7_DrawPrimitive(&device->IDirect3DDevice7_iface, device->primitive_type,
> +    return IDirect3DDevice3_DrawPrimitive(&device->IDirect3DDevice3_iface, device->primitive_type,
>              device->vertex_type, device->sysmem_vertex_buffer, device->nb_vertices, device->render_flags);
> This is not introduced by your patch of course, but I don't think
> there's much of a point in going through the vtbl here.

[PATCH 2/4] ddraw: Send device2_Draw* through device3_Draw*

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-06-20 13:02, schrieb Henri Verbeet:
> On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com>
> wrote:
> > -    return
> > IDirect3DDevice7_DrawPrimitive(&device->IDirect3DDevice7_iface,
> > device->primitive_type, +    return
> > IDirect3DDevice3_DrawPrimitive(&device->IDirect3DDevice3_iface,
> > device->primitive_type, device->vertex_type,
> > device->sysmem_vertex_buffer, device->nb_vertices,
> > device->render_flags);
> > This is not introduced by your patch of course, but I don't think 
> > there's much of a point in going through the vtbl here.
> > Right. Although it made sense for calling device7 because of the
> > fpu_preserve and fpu_setup vtables.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRwuMCAAoJEN0/YqbEcdMwqWoQAJdGD4wWu1uAGmew+mj5kn3K
Ys/EzJqN5Njf3heGad60E5+8Gpv1xrVH9I4BsPpmAhE2NaAXkOH5/HDmD8bdy2Cv
tlaqvHQueXs3kfTMLswk/3I3A4Y3NJk2HqP9VRv1mBRbzk3MFV4W8ZcZS7wIRZEw
ikhkH7EeB351wN1NFJE/RJ9w+rDWCcBSTwGWEBCzRxku8MPC1ueUpNDWzqkWUklC
6sFea0BR32XaANqDhxo4vMmQL3NNqTSLBpIIwfP7JpABpNTYJp4dRgwNLWQxCG2x
fqL/KnCQe5kM7Hm58qvdF2pZo/Iu3sFV0F//jb5k7Ku9yj0pJOHp9uXRlRsJVrCx
JAjUC3hit7xPu7MjJEStRhBEfqlSH1pJ2M4kE1pQU6sO0rR4ZE+JrQJzYl9E7mLq
Gj+IF8823SpBrYCYM97fcfgX2gzbYp0TMuzgn7TMYyD/IUzyDaqrEQdL0hXLQJBB
MdCF2eZJKXGftzM9DUfwO/bbKCUk+png29JT2gP78asTu+9/AJEE3+Kw2MIEv79i
dN51tY8wqGSrieZvIJ7h5kSV5pLGxjIqwlfgK1f8XFo7qYfJLmQ+Q5dB1zpYq5tZ
w7LmXEck2w4yYLXS9QRXrGgmt9YdEmkvvuXpBcnje/d3kDctuRKtDFSXPf0DhtNw
YLx3zQRpPdUe3Zk9Tiox
=O23d
-----END PGP SIGNATURE-----