user32: the patches - what's wrong?

[Kirill K. Smirnov]

Hi,

Traditional questions from rejected patch-sender:

1) What's wrong with the following patches?
http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html
http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html

2) What can be done to improve them?

Those patches let the window proc repaint NC area instead of calling NCPaint 
directly.
And changes processing of WM_SETICON to be similar with WM_SETTEXT.

-- Kirill

[Alexandre Julliard]

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes:
> Traditional questions from rejected patch-sender:
>
> 1) What's wrong with the following patches?
> http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html
> http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html
>
> 2) What can be done to improve them?

You should add tests in tests/msg.c to show that your changes yield
the same message sequence as on Windows.

-- 
Alexandre Julliard
julliard(a)winehq.org