Re: [PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes

[Alexandre Julliard]

Eric Pouech <eric.pouech(a)orange.fr> writes:
> index 8181469..bf942a4 100644
> --- a/programs/winhelp/hlpfile.c
> +++ b/programs/winhelp/hlpfile.c
> @@ -158,8 +158,8 @@ HLPFILE_PAGE *HLPFILE_PageByOffset(HLPFILE* hlpfile, LONG offset)
>  static int comp_PageByHash(void *p, const void *key,
>                             int leaf, void** next)
>  {
> -    ULONG_PTR lKey = (LONG_PTR)key;
> -    ULONG_PTR lTest = GET_UINT(p, 0);
> +    LONG_PTR lKey = (LONG_PTR)key;
> +    LONG_PTR lTest = GET_UINT(p, 0);

This won't work on 64-bit. If the hash really needs to be signed (why?)
you need some extra casts.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes

[Eric Pouech]

> This won't work on 64-bit. If the hash really needs to be signed (why?)
> you need some extra casts.

signed comparison is needed below for finding the key in the btree
currently, most of the navigation in hlp files is broken because of this
patch
A+
> --
> Alexandre Julliard
> julliard(a)winehq.org

-- 
-- 
Eric Pouech