Re: advapi32/tests: Use BOOL type where appropriate

[Dmitry Timoshkov]

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote:
> diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
> index 9f1e611..232a729 100644
> --- a/dlls/advapi32/tests/security.c
> +++ b/dlls/advapi32/tests/security.c
> @@ -4526,13 +4526,14 @@ static void test_mutex_security(HANDLE token)
>                                  STANDARD_RIGHTS_ALL | MUTEX_ALL_ACCESS };
>      static const struct
>      {
> -        int todo, generic, mapped;
> +        BOOL todo;
> +        int generic, mapped;
>      } map[] =
>      {
> -        { 1, GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE },
> -        { 0, GENERIC_WRITE, STANDARD_RIGHTS_WRITE },
> -        { 0, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE },
> -        { 0, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE }
> +        { TRUE,  GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE },
> +        { FALSE, GENERIC_WRITE, STANDARD_RIGHTS_WRITE },
> +        { FALSE, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE },
> +        { FALSE, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE }
>      };

Please don't touch these tests, 'int' is intentionally used here, and 'BOOL'
buys you nothing. It's better to actually fix the source of these todos and
remove them altogether.

-- 
Dmitry.