Re: [PATCH 2/2] msi: Remove full reinstall special handling

[Hans Leidekker]

On Wed, 2017-10-18 at 17:25 +0200, Piotr Caban wrote:
> This patch fixes "change office 2010 serial key" functionality.

This code was introduced to fix the Enterprise Architect installer
after I broke it with e2900c23c7f0b143078da780c9a0ff19a895bf45.
(see https://bugs.winehq.org/show_bug.cgi?id=32387).

Your patch breaks this installer again because the condition for
entering the maintenance dialog tests the Preselected property.

Given your test it seems that we shouldn't set REINSTALL at all
(since it causes Preselected to be set) or that we should set it
only after evaluating command line overrides.

[PATCH 2/2] msi: Remove full reinstall special handling

[Piotr Caban]

On 10/19/17 12:25, Hans Leidekker wrote:
> On Wed, 2017-10-18 at 17:25 +0200, Piotr Caban wrote:
> > This patch fixes "change office 2010 serial key" functionality.
>
> This code was introduced to fix the Enterprise Architect installer
> after I broke it with e2900c23c7f0b143078da780c9a0ff19a895bf45.
> (see https://bugs.winehq.org/show_bug.cgi?id=32387).
>
> Your patch breaks this installer again because the condition for
> entering the maintenance dialog tests the Preselected property.
>
> Given your test it seems that we shouldn't set REINSTALL at all
> (since it causes Preselected to be set) or that we should set it
> only after evaluating command line overrides.

Thank you. I'll try to find a solution suitable for Office and 
Enterprise Architect.

Thanks,
Piotr