Re: server: allow OpenClipboard to succeed when already open

[James Hawkins]

On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote:
> When OpenClipboard is called twice in a row with the same HWND as a
> parameter, wine lets the first call succeed, but the second call fails
> because the clipboard was already locked.  Although it's not specified
> in the docs, Windows allows the second call to succeed (and something
> deep inside of our app depends on this).  I think I submitted a version
> of this patch a year or two back, but it wasn't accepted.

You should add a unit test for this case in Wine's test suite.  It
would be pretty easy to write, and it would verify this information,
making your fix more likely to be accepted.

--
James Hawkins

server: allow OpenClipboard to succeed when already open

[Michael Stefaniuc]

James Hawkins wrote:
> On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote:
> > When OpenClipboard is called twice in a row with the same HWND as a
> > parameter, wine lets the first call succeed, but the second call fails
> > because the clipboard was already locked.  Although it's not specified
> > in the docs, Windows allows the second call to succeed (and something
> > deep inside of our app depends on this).  I think I submitted a version
> > of this patch a year or two back, but it wasn't accepted.
>
> You should add a unit test for this case in Wine's test suite.  It
> If you look at the bottom of his patch you will see that he already did 
> that ... .
> would be pretty easy to write, and it would verify this information,
> making your fix more likely to be accepted.

bye
	michael
-- 
Michael Stefaniuc               Tel.: [phone]
Sr. Network Engineer            Fax.: [phone]
Red Hat GmbH                    Email: mstefani(a)redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart

server: allow OpenClipboard to succeed when already open

[James Hawkins]

On 2/7/06, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
> > You should add a unit test for this case in Wine's test suite.  It
>
> If you look at the bottom of his patch you will see that he already did
> that ... .

oops :)

--
James Hawkins

server: allow OpenClipboard to succeed when already open

[Dmitry Timoshkov]

On Tue, 2006-02-07 at 15:05 -0600, James Hawkins wrote:
> You should add a unit test for this case in Wine's test suite.  It
> would be pretty easy to write, and it would verify this information,
> making your fix more likely to be accepted.

A test is included in the patch.

-- 
Dmitry.