Re: services: Issue a fixme when a service fails to start.

[Octavian Voicu]

On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote:
> @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct scmdatabase *db)
>         argv[0] = service->name;
>         argv[1] = NULL;
>         err = service_start(service, 1, argv);
> -        /* FIXME: do something if the service failed to start */
> +        if (err != ERROR_SUCCESS)
> +            WINE_FIXME("do something if the service failed to start %d\n", err);

Why not print something more informative? This looks nice and also
tells you which service did not start:
WINE_FIXME("Auto-start service %s failed to start: %d\n",
wine_dbgstr_w(service->name), err);

Octavian