Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
On 12 November 2014 22:15, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
+void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) +{ + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) + ShowWindow(swapchain->device_window, SW_MINIMIZE); +} This patch is mostly just blocked by the tests failing, but I'd also have to wonder if the window proc should be installed in the first place if the device is created with NOWINDOWCHANGES.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-13 11:44, schrieb Henri Verbeet:
This patch is mostly just blocked by the tests failing, but I'd also have to wonder if the window proc should be installed in the first place if the device is created with NOWINDOWCHANGES. The tests say yes - patch 3 adds NOWINDOWCHANGES to test_wndproc, and the window proc is still modififed.
Even with NOWINDOWCHANGES d3d9 restores the screen resolution on focus loss, and it knows about focus loss somehow (TestCooperativeLevel returns the expected values), and replacing the wndproc is kinda necessary for both of these. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUZJHQAAoJEN0/YqbEcdMwHlEP/RnugjwwACCms0/nLIon7n11 zsj3RDbYf2N3BKc8UgC3jD85pd8kLC+t+VKCsrUUZStPTlLe4tl3gkL05l1VorJs h4JZoRAa6Qt3YrcfW11VXuqNqoyt8YXTvSTh+JrtijdzPOMgefB0tr+EjLXRQNY1 xBnNam3LUyw7NfRz3QdKFD4uXhJtyc8bhBvR2VIWLa1jMwlsV8LuWTgRh7DyCEjZ lMJ5cPYjjERRCU+1h5Y+nUHiXqFWAB6hWoBud1lKrnJfJCqsuJ7udrsKi73g+FcG XZ4VHbMurdpjwjT4BnnTtEDF/yjolV19CoSH9D7OfjgKJe8vrV3JzRLSW8y2O7bS cNMajIlk3ywTqMzH2ZEmzungBW8Ldpi7sE3clRhrJRWgRlty623zfR6Wc8vo5z3U 6qgrU2WCejUM3t74t15cFEHfpg3sT25iGD/XWskW7EcrrdWudEjJo01/fTT6eOeF GF52FPUaiwfQ+alQXHDAw5NcVcLsiA0gi35SQ9ebYdpMwrC1W/HXxB0t8fidfZu7 +/Ttu9qUxUZlay/lB5YBiSe7QHCWj9Vf/tfcbjsqCPrD/ov4/C1a+/mO8Ot3FNAZ IBMDrdJ+M74hVHkkjncg9gRtwOrHN9w2ywav28+02vidjqHQg2KwpQHElUMem5n0 eVVETgwSARjaxy3kAuvV =Mc7Q -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger