Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

[Hans Leidekker]

On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote:
> +/* unfortunately GetProcAddress cannot return proper pointer to
> from_bmformat() function, but for this function it's not a problem,
> using copy from ../transform.c */

That's not how it's done in Wine, you will need to go through the
API. In this case that means you need to define a bitmap in the
appropriate format, create a color transform and then call
TranslateBitmapBits.

Note that Wine doesn't bundle a color profile, so you need to
install one, or configure your X server to use one and retrieve
it via GetICMProfile.

[PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

[Tomasz Michno]

Hi,
> That's not how it's done in Wine, you will need to go through the
> API. In this case that means you need to define a bitmap in the
> appropriate format, create a color transform and then call
> TranslateBitmapBits.

I thought that I only need to test function which I modified, so I
created tests in that way. Now I'm modifying them to use
TranslateBitmapBits. Should I resend the whole patch or only create
one new with only tests/transform.c?
I tested wine with my modification with different images (including
raw's) and applications and all works well.

thanks for your time and help
Tomasz Michno

[PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

[Hans Leidekker]

On Tue, 2010-10-19 at 17:35 +0200, Tomasz Michno wrote:
> I thought that I only need to test function which I modified, so I
> created tests in that way. Now I'm modifying them to use
> TranslateBitmapBits. Should I resend the whole patch or only create
> one new with only tests/transform.c?

Please resend the whole patch.