Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> @@ -748,6 +748,11 @@ err:
>      }
>      else
>      {
> +        if (type == FD_TYPE_FILE)
> +        {
> +            io_status->u.Status = status;
> +            io_status->Information = total;
> +        }

I don't see why this would have to be specific to files.

-- 
Alexandre Julliard
julliard(a)winehq.org

[5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> > +        if (type == FD_TYPE_FILE)
> > +        {
> > +            io_status->u.Status = status;
> > +            io_status->Information = total;
> > +        }
>
> I don't see why this would have to be specific to files.

There is a test for pipes which fails if there is no this limitation.

-- 
Dmitry.

[5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> Alexandre Julliard <julliard(a)winehq.org> wrote:
> > > +        if (type == FD_TYPE_FILE)
> > > +        {
> > > +            io_status->u.Status = status;
> > > +            io_status->Information = total;
> > > +        }
> >
> > I don't see why this would have to be specific to files.
>
> There is a test for pipes which fails if there is no this limitation.

That's not very convincing. There are many more possible code paths in
there.

-- 
Alexandre Julliard
julliard(a)winehq.org