review: add Video Memory text input to winecfg Graphics/Direct3D tab
Hi, the attached patch adds new textbox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. Updated every live locale resource to include this. Adding this option was discussed on thread 'More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)' at wine-devel. changelog entry: Add Video Memory textbox to Graphics/direct3D part of winecfg May I kindly ask someone for the patch review? Regards Vit Hrachovy
Am Freitag 27 April 2007 09:23 schrieb Vit Hrachovy:
Hi, the attached patch adds new textbox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. Updated every live locale resource to include this.
Adding this option was discussed on thread 'More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)' at wine-devel.
changelog entry: Add Video Memory textbox to Graphics/direct3D part of winecfg
May I kindly ask someone for the patch review? On a quick look I see a number of whitespace issues in the patch. in the .rc files you are using tabs while the rest of the code uses spaces at some places, in other lines you're using spaces yourself. In the code you add some trailing whitespace(Git warns about that in rebase and git-am
As for the German translation you could use "Größe des Grafikspeichers(in Megabytes)"
On Fri, Apr 27, 2007 at 12:14:47PM +0200, Stefan Dösinger wrote:
On a quick look I see a number of whitespace issues in the patch. in the .rc files you are using tabs while the rest of the code uses spaces at some places, in other lines you're using spaces yourself. In the code you add some trailing whitespace(Git warns about that in rebase and git-am
As for the German translation you could use "Größe des Grafikspeichers(in Megabytes)"
Hi Stefan, thanks for comments, I'm including the fixed patch with added German translation. Thanks Vit
On 27.04.2007 09:23, Vit Hrachovy wrote:
Hi, the attached patch adds new textbox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. Updated every live locale resource to include this.
Some thoughts on the UI: - Maybe make it an editable combobox with common sizes in the dropdown (64, 128, 256 ...) for convenience. - It looks like the field is left empty when no video memory setting is found in the registry. Maybe it's better to show the default value from wined3d then? -f.r.
participants (3)
-
Frank Richter -
Stefan Dösinger -
Vit Hrachovy