cvs doesn't build .. my fault?

[Paul Millar]

Hi,

A couple of things:

First, I've noticed cvs didn't build for me anymore. The problem was
because I removed the header files for ncurses (ie removed the
ncurses-devel RPM).  The file dlls/ttydrv/bitmap.c then failed to compile.

Having had a look at the code in ttydrv, its fairly obvious it wont build
without either curses or ncurses installed. A simple patch (wine-diff-1)
provides a better error message. It shouldn't be needed (with the next
patch), but might help bug finding in the future.

But, shouldn't wine simply abstain from building ttydrv if a (n?)curses
package isn't available? I've attached another patch (wine-diff-2) that
does that. AFAIK, there's no knock-on effects.


Second problem, when attempting to verify the build-failure on a different
machine (hathi), it failed, but in a different part of the build! It only
succeeded on the third machine (romulus)

On hathi, a RH-7.0 (w/ Linus-2.4.3 kernel) I got:
> make[2]: Entering directory `/disk/hathi1/paulm/wine/dlls/ntdll'
> LD_LIBRARY_PATH="../../unicode:$LD_LIBRARY_PATH" 
> ../../tools/winebuild/winebuild -fPIC -L../../dlls  -o ntdll.spec.c 
> -spec ./ntdll.spec
> make[2]: *** [ntdll.spec.c] Segmentation fault (core dumped)
>  [...]

After some investigation, it transpires that gcc on hathi (the RH-7.0
machine) builds broken winebuild programs (the unicode library was fine).
The RH-7.1 (romulus) could "fix" the problem by recompiling just the
winebuild directory.

The problem turned out to be because I had old gcc-2.96 RPMs installed.  
After updating to the latest upgrade RPMs winebuild is built correctly,
but wrc is now broken: it segfaults whenever its run.

Can anyone with a 7.0 machine verify this?

Cheers,

Paul.

[Alexandre Julliard]

Paul Millar <paulm(a)astro.gla.ac.uk> writes:
> Having had a look at the code in ttydrv, its fairly obvious it wont build
> without either curses or ncurses installed. A simple patch (wine-diff-1)
> provides a better error message. It shouldn't be needed (with the next
> patch), but might help bug finding in the future.

Actually ttydrv usually builds just fine without curses, it's just
that my last patch broke it. It should be fixed now.

-- 
Alexandre Julliard
julliard(a)winehq.com

[Paul Millar]

On 29 Mar 2002, Alexandre Julliard wrote:
> Actually ttydrv usually builds just fine without curses, it's just
> that my last patch broke it. It should be fixed now.

Yep, seems to be fixed now. WRT should relect this after the next compile 
cycle.

Cheers,

Paul.

[Francois Gouget]

On Fri, 29 Mar 2002, Paul Millar wrote:
> Hi,
>
> A couple of things:
>
> First, I've noticed cvs didn't build for me anymore. The problem was
> because I removed the header files for ncurses (ie removed the
> ncurses-devel RPM).  The file dlls/ttydrv/bitmap.c then failed to compile.
>
> Having had a look at the code in ttydrv, its fairly obvious it wont build
> without either curses or ncurses installed. A simple patch (wine-diff-1)
> provides a better error message. It shouldn't be needed (with the next
> patch), but might help bug finding in the future.
>
> But, shouldn't wine simply abstain from building ttydrv if a (n?)curses
> package isn't available? I've attached another patch (wine-diff-2) that
> does that. AFAIK, there's no knock-on effects.

Could this be that you did not re-run a clean configure?


--
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
                Linux: It is now safe to turn on your computer.