Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)
19 Jul
2010
19 Jul
'10
11:10 a.m.
On 17 July 2010 21:14, Misha Koshelev <misha680(a)gmail.com> wrote:
@@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void) IDirect3DVertexBuffer9_Release(vertex_buffer); }
+ /* Index buffer */ + number_of_faces = box->lpVtbl->GetNumFaces(box); + todo_wine ok( number_of_faces == 12, "Got result %u, expected 12\n",number_of_faces); + box->lpVtbl->Release(box); }
I think this could easily have been part of the original test as well. It's good to send small patches that make sense on their own, but I don't think there's much to be gained by splitting up a patch that adds a test for a single function.
5630
Age (days ago)
5630
Last active (days ago)
0 comments
1 participants
participants (1)
-
Henri Verbeet