[PATCH] user32/tests: Move test_mdi early in the test list.

[Rémi Bernon]

The test gets spurious GetScrollInfo SB_HORZ failures if some other
windows were created before using CW_USEDEFAULT positions, for instance
the window from test_capture_4.

This happened on some Win10 VMs, and was thought to be fixed with
9b5346df86bf1a85336ed03a67a630970ce08e9f, but it then broke the test on
some other VMs. This is hopefully a better fix, and it reverts the
previous one too.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=52507
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---
 dlls/user32/tests/win.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c
index 8ec6d8af064..8614a048c4d 100644
--- a/dlls/user32/tests/win.c
+++ b/dlls/user32/tests/win.c
@@ -2256,7 +2256,7 @@ static void test_mdi(void)
     mdi_hwndMain = CreateWindowExA(0, "MDI_parent_Class", "MDI parent window",
                                    WS_CAPTION | WS_SYSMENU | WS_MINIMIZEBOX |
                                    WS_MAXIMIZEBOX /*| WS_VISIBLE*/,
-                                   200, 100, CW_USEDEFAULT, CW_USEDEFAULT,
+                                   100, 100, CW_USEDEFAULT, CW_USEDEFAULT,
                                    GetDesktopWindow(), 0,
                                    GetModuleHandleA(NULL), NULL);
     assert(mdi_hwndMain);
@@ -12644,6 +12644,10 @@ START_TEST(win)
 
     our_pid = GetWindowThreadProcessId(hwndMain, NULL);
 
+    /* This test is sensitive to other windows created with
+     * CW_USEDEFAULT position, execute it early too */
+    test_mdi();
+
     /* Add the tests below this line */
     test_child_window_from_point();
     test_window_from_point(argv[0]);
@@ -12665,7 +12669,6 @@ START_TEST(win)
     test_parent_owner();
     test_enum_thread_windows();
 
-    test_mdi();
     test_icons();
     test_SetWindowPos(hwndMain, hwndMain2);
     test_SetMenu(hwndMain);
-- 
2.34.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=107224

Your paranoid android.


=== w864 (32 bit report) ===

user32:
win.c:2399: Test failed: style 0x200000: expected !100
win.c:2399: Test failed: style 0x300000: expected !100

=== w864 (64 bit report) ===

user32:
win.c:2399: Test failed: style 0x200000: expected !100
win.c:2399: Test failed: style 0x300000: expected !100

=== debian11 (32 bit Japanese:Japan report) ===

user32:
win.c:10702: Test failed: Expected foreground window 00020052, got 00F600C2
win.c:10704: Test failed: GetActiveWindow() = 00000000
win.c:10704: Test failed: GetFocus() = 00000000
win.c:10705: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.