Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

[Alexandre Julliard]

Charles Davis <cdavis(a)mymail.mines.edu> writes:
> Try 6: Fix some problems noticed by Vitaliy Margolen.
> Try 5: Get the value of "DeviceName" from mountmgr instead of making one up.
> Try 4: Fix unused variable warning.
> Try 3: Add support for IDE drives.
> Try 2: Don't depend on the SCSI generic driver on Linux.
>
> ---
>  dlls/kernel32/Makefile.in    |    1 -
>  dlls/kernel32/oldconfig.c    |  404 ------------------------------------------
>  dlls/kernel32/process.c      |    3 -
>  dlls/mountmgr.sys/device.c   |  192 ++++++++++++++++++++-
>  dlls/mountmgr.sys/diskarb.c  |    2 +-
>  dlls/mountmgr.sys/hal.c      |  207 +++++++++++++++++++++-
>  dlls/mountmgr.sys/mountmgr.c |    6 +-
>  dlls/mountmgr.sys/mountmgr.h |   37 ++++-
>  8 files changed, 439 insertions(+), 413 deletions(-)
>  delete mode 100644 dlls/kernel32/oldconfig.c

Now it's not setting DeviceName at all here.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

[Charles Davis]

On 5/10/11 11:11 AM, Alexandre Julliard wrote:
> Charles Davis <cdavis(a)mymail.mines.edu> writes:
> > Try 6: Fix some problems noticed by Vitaliy Margolen.
> > Try 5: Get the value of "DeviceName" from mountmgr instead of making one up.
> > Try 4: Fix unused variable warning.
> > Try 3: Add support for IDE drives.
> > Try 2: Don't depend on the SCSI generic driver on Linux.
> >
> > ---
> >  dlls/kernel32/Makefile.in    |    1 -
> >  dlls/kernel32/oldconfig.c    |  404 ------------------------------------------
> >  dlls/kernel32/process.c      |    3 -
> >  dlls/mountmgr.sys/device.c   |  192 ++++++++++++++++++++-
> >  dlls/mountmgr.sys/diskarb.c  |    2 +-
> >  dlls/mountmgr.sys/hal.c      |  207 +++++++++++++++++++++-
> >  dlls/mountmgr.sys/mountmgr.c |    6 +-
> >  dlls/mountmgr.sys/mountmgr.h |   37 ++++-
> >  8 files changed, 439 insertions(+), 413 deletions(-)
> >  delete mode 100644 dlls/kernel32/oldconfig.c
>
> Now it's not setting DeviceName at all here.
> As far as I can tell, this is a limitation of the way mountmgr works. It
> only assigns a device name when a disk is in the drive. I take it you
> want me to fix that?

Chip

[PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

[Alexandre Julliard]

Charles Davis <cdavis(a)mymail.mines.edu> writes:
> > Now it's not setting DeviceName at all here.
> > As far as I can tell, this is a limitation of the way mountmgr works. It
> > only assigns a device name when a disk is in the drive. I take it you
> > want me to fix that?

Ultimately we'll want to create the devices even without a disk in the
drive, but that can be a separate patch. For now setting the name only
when it's mounted would be good enough.

-- 
Alexandre Julliard
julliard(a)winehq.org