Re: [PATCH 1/2] kernel32: Add tests for creating directories with specific security attributes.

[Dmitry Timoshkov]

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> wrote:
> Currently CreateDirectory mostly ignores the security attributes on
> directories.  This patch adds some tests for what happens when these
> attributes are present and part 2 adds support for setting these
> attributes.

This patch duplicates already existing tests in dlls/advapi32/tests/security.c.

-- 
Dmitry.

[PATCH 1/2] kernel32: Add tests for creating directories with specific security attributes.

[Erich E. Hoover]

On Sun, Nov 10, 2013 at 10:48 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> "Erich E. Hoover" <erich.e.hoover(a)gmail.com> wrote:
> > Currently CreateDirectory mostly ignores the security attributes on
> > directories.  This patch adds some tests for what happens when these
> > attributes are present and part 2 adds support for setting these
> > attributes.
>
> This patch duplicates already existing tests in dlls/advapi32/tests/security.c.

In advapi32 I was trying to test Set[Named]SecurityInfo, here I'm
trying to test CreateDirectory (a kernel32 component).  Would you
prefer that this test be in advapi32?

Best,
Erich

[PATCH 1/2] kernel32: Add tests for creating directories with specific security attributes.

[Dmitry Timoshkov]

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> wrote:
> > > Currently CreateDirectory mostly ignores the security attributes on
> > > directories.  This patch adds some tests for what happens when these
> > > attributes are present and part 2 adds support for setting these
> > > attributes.
> >
> > This patch duplicates already existing tests in dlls/advapi32/tests/security.c.
>
> In advapi32 I was trying to test Set[Named]SecurityInfo, here I'm
> trying to test CreateDirectory (a kernel32 component).  Would you
> prefer that this test be in advapi32?

Yes, it would be better to have these tests in one place, that would
also avoid duplicating all those soft API imports.

-- 
Dmitry.