Re: [3/5] ddraw/tests: add test for D3DRENDERSTATE_TEXTUREMAPBLEND state

[H. Verbeet]

On 02/01/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote:
> Tests of behavior introduced by patches 4/5 and 5/5.
> ---
> Going by the commit message, I assume this test would currently fail?
> You can't do that. You either have to send the patches that fix the
> problem first, or you have to wrap the failing tests in todo_wine
> blocks, and remove the todo_wine blocks in the patch that fixes the
> tests they wrap.

[3/5] ddraw/tests: add test for D3DRENDERSTATE_TEXTUREMAPBLEND state

[Stefan Dösinger]

Am Mittwoch, 2. Januar 2008 09:21:14 schrieb H. Verbeet:
> On 02/01/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote:
> > Tests of behavior introduced by patches 4/5 and 5/5.
> > ---
>
> Going by the commit message, I assume this test would currently fail?
> You can't do that. You either have to send the patches that fix the
> problem first, or you have to wrap the failing tests in todo_wine
> blocks, and remove the todo_wine blocks in the patch that fixes the
> tests they wrap.
> Appart of this issue I recommend to move the D3D1 creation into a separate 
> function. Eventually more D3D1 tests will be written, and we want to 
> discourage copypasting that huge block of code.