Re: shell32: change return value of SHFileOperation when deleting files

[Nikolay Sivov]

On 11/26/2013 19:37, Zhenbo Li wrote:
> This patch should fix bug 34324.
> Does it actually fix it? Cause a hack attached to this bug differs from 
> what you're doing.
> Another thing to test is to try this application on Vista or later to 
> see if it works.
> When deleting files, I can't find a situation to return 
> ERROR_PATH_NOT_FOUND
> ---
>  dlls/shell32/shlfileop.c       | 2 +-
>  dlls/shell32/tests/shlfileop.c | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)

shell32: change return value of SHFileOperation when deleting files

[Qian Hong]

On Tue, Nov 26, 2013 at 11:44 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> Does it actually fix it? Cause a hack attached to this bug differs from what
> you're doing.
> I wrote the original hack, it does fix the app, as well as Zhenbo's patch.
> Another thing to test is to try this application on Vista or later to see if
> it works.
> Yes it works, the app is smart enough to handle both 0x402 and 0x2.

-- 
Regards,
Qian Hong

-
http://www.winehq.org

shell32: change return value of SHFileOperation when deleting files

[Nikolay Sivov]

On 11/26/2013 20:35, Qian Hong wrote:
> On Tue, Nov 26, 2013 at 11:44 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> > Does it actually fix it? Cause a hack attached to this bug differs from what
> > you're doing.
> > I wrote the original hack, it does fix the app, as well as Zhenbo's patch.
> > Another thing to test is to try this application on Vista or later to see if
> > it works.
> > Yes it works, the app is smart enough to handle both 0x402 and 0x2.
> > Ok, it's better to return 0x2 value then as this patch does.

shell32: change return value of SHFileOperation when deleting files

[Alexandre Julliard]

Nikolay Sivov <bunglehead(a)gmail.com> writes:
> On 11/26/2013 20:35, Qian Hong wrote:
> > On Tue, Nov 26, 2013 at 11:44 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> > > Does it actually fix it? Cause a hack attached to this bug differs from what
> > > you're doing.
> > > I wrote the original hack, it does fix the app, as well as Zhenbo's patch.
> > > Another thing to test is to try this application on Vista or later to see if
> > > it works.
> > > Yes it works, the app is smart enough to handle both 0x402 and 0x2.
> > > Ok, it's better to return 0x2 value then as this patch does.

It would be even better to return the actual error from the
corresponding file operations...

-- 
Alexandre Julliard
julliard(a)winehq.org