Re: richedit: Implemented EM_STOPGROUPTYPING, fixed undo grouping (with tests)
Dylan Smith escribió:
EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The remarks for this message on MSDN explains what events stops group typing, which led me to adding the delete key to the actions that stop group typing.
The tests that are included with this patch verify the correctness of the changes.
This patch depends on a previous patch I submitted, which has an email subject "[6/44] richedit: Implemented undo coalescing to group typing events", and was submitted on June 17. --- dlls/riched20/editor.c | 12 ++++++++++-- dlls/riched20/tests/editor.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 2 deletions(-)
This patch has the corresponding test. Could you please send a patch (one or more) that would test the behaviors fixed by the previous patches? This will make it more likely for AJ to accept the patches, and will also prevent someone (such as myself) from accidentally breaking fixed behavior with further changes. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
Alex Villacís Lasso wrote:
Dylan Smith escribió:
EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The remarks for this message on MSDN explains what events stops group typing, which led me to adding the delete key to the actions that stop group typing.
The tests that are included with this patch verify the correctness of the changes.
This patch depends on a previous patch I submitted, which has an email subject "[6/44] richedit: Implemented undo coalescing to group typing events", and was submitted on June 17. --- dlls/riched20/editor.c | 12 ++++++++++-- dlls/riched20/tests/editor.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 2 deletions(-)
This patch has the corresponding test. Could you please send a patch (one or more) that would test the behaviors fixed by the previous patches? This will make it more likely for AJ to accept the patches, and will also prevent someone (such as myself) from accidentally breaking fixed behavior with further changes.
Alex: You are talking about fixing things. I was fixing EM_FONTRANGE before 1.0 as it breaks several things. Are you looking to pick this up as one of the things you are going to fix? James McKenzie
James McKenzie escribió:
This patch has the corresponding test. Could you please send a patch (one or more) that would test the behaviors fixed by the previous patches? This will make it more likely for AJ to accept the patches, and will also prevent someone (such as myself) from accidentally breaking fixed behavior with further changes.
Alex:
You are talking about fixing things. I was fixing EM_FONTRANGE before 1.0 as it breaks several things. Are you looking to pick this up as one of the things you are going to fix?
James McKenzie
I am assuming you meant EM_FORMATRANGE, since a MSDN search for EM_FONTRANGE yielded nothing, but Google yielded an old patch by you for EM_FORMATRANGE. I was not planning to tackle EM_FORMATRANGE for the moment. My plans involving riched20 in Wine (barring the fixing of any more regressions) were to prepare a patch to tone down the EM_AUTOURLDETECT tests, then to take a look at the valgrind report from Dan Kegel, then to investigate and prepare tests for the scrollbar recursion problem for bug #12311, and finally to investigate horizontal scrolling support in richedit, which is apparently completely unimplemented (not a single call to SetScrollInfo(SB_HORZ), for example). Does this help? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
Neither am I looking to work on EM_FORMATRANGE. I am trying to get my work on tables to be in a more stable state, since richedit controls need to be able to support nested paragraphs for the v4.1 implementation of tables (i.e. a table row is a paragraph, and cells are a container of nested paragraphs/table rows). On Thu, Jun 26, 2008 at 10:35 PM, James McKenzie <jjmckenzie51(a)sprintpcs.com> wrote:
Alex Villacís Lasso wrote:
Dylan Smith escribió:
EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The remarks for this message on MSDN explains what events stops group typing, which led me to adding the delete key to the actions that stop group typing.
The tests that are included with this patch verify the correctness of the changes.
This patch depends on a previous patch I submitted, which has an email subject "[6/44] richedit: Implemented undo coalescing to group typing events", and was submitted on June 17. --- dlls/riched20/editor.c | 12 ++++++++++-- dlls/riched20/tests/editor.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 2 deletions(-)
This patch has the corresponding test. Could you please send a patch (one or more) that would test the behaviors fixed by the previous patches? This will make it more likely for AJ to accept the patches, and will also prevent someone (such as myself) from accidentally breaking fixed behavior with further changes.
Alex:
You are talking about fixing things. I was fixing EM_FONTRANGE before 1.0 as it breaks several things. Are you looking to pick this up as one of the things you are going to fix?
James McKenzie
participants (3)
-
Alex Villacís Lasso -
Dylan Smith -
James McKenzie