Re: [PATCH 1/4] ntdll: Use correct parameter types instead of casting.

[Sebastian Lackner]

On 30.12.2015 06:37, Alex Henrie wrote:
> Casting has not been necessary here ever since this code was converted
> to use wineserver requests circa Wine 1.0.
>
> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
> ---
>  dlls/ntdll/file.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
> index 1027b54..6524f32 100644
> --- a/dlls/ntdll/file.c
> +++ b/dlls/ntdll/file.c
> @@ -411,10 +411,8 @@ static struct async_fileio *alloc_fileio( DWORD size, HANDLE handle, PIO_APC_ROU
>  }
>
> /* callback for irp async I/O completion */
> -static NTSTATUS irp_completion( void *user, IO_STATUS_BLOCK *io, NTSTATUS status, void **apc, void **arg )
> +static NTSTATUS irp_completion( struct async_irp *async, IO_STATUS_BLOCK *io, NTSTATUS status, void **apc, void **arg )
>  {

It would no longer match the prototype in dlls/ntdll/server.c then:

        NTSTATUS (*func)(void *, IO_STATUS_BLOCK *, NTSTATUS, void **, void **) = wine_server_get_ptr( call->async_io.func );

[PATCH 1/4] ntdll: Use correct parameter types instead of casting.

[Alex Henrie]

2015-12-29 23:01 GMT-07:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> On 30.12.2015 06:37, Alex Henrie wrote:
> > Casting has not been necessary here ever since this code was converted
> > to use wineserver requests circa Wine 1.0.
> >
> > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
> > ---
> >  dlls/ntdll/file.c | 13 ++++---------
> >  1 file changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
> > index 1027b54..6524f32 100644
> > --- a/dlls/ntdll/file.c
> > +++ b/dlls/ntdll/file.c
> > @@ -411,10 +411,8 @@ static struct async_fileio *alloc_fileio( DWORD size, HANDLE handle, PIO_APC_ROU
> >  }
> >
> > /* callback for irp async I/O completion */
> > -static NTSTATUS irp_completion( void *user, IO_STATUS_BLOCK *io, NTSTATUS status, void **apc, void **arg )
> > +static NTSTATUS irp_completion( struct async_irp *async, IO_STATUS_BLOCK *io, NTSTATUS status, void **apc, void **arg )
> >  {
>
> It would no longer match the prototype in dlls/ntdll/server.c then:
>
> NTSTATUS (*func)(void *, IO_STATUS_BLOCK *, NTSTATUS, void **, void **) = wine_server_get_ptr( call->async_io.func );

OK, that's fine. I'm happy to drop this patch.

I do, however, still have 8 more patches in the queue that I would
really like to have reviewed before I send anything more major...

-Alex