Re: Preliminary CD-Rom support on MacOS X #5

[Markus Amsler]

Hi,

I took a look at your patches, here's what i've found:

ntdll_cdrom.diff:
> #
>
> @ cdecl MODULE_DllThreadAttach(ptr)
> @ cdecl MODULE_GetLoadOrderW(ptr wstr wstr)
> +@ cdecl CDROM_InitCDDevices()
> +@ cdecl CDROM_FoundDevices()
> +@ cdecl CDROM_BSDPathForMedia(ptr)
> +@ cdecl CDROM_GetMountPointForBSDDevice(ptr)
> +@ cdecl CDROM_BSDPathForHandle(long)
> \ No newline at end of file

- You shouldn't add more seperation hacks. Besides that, if _APPLE_ is not defined, the linker doesn't find these symbols.
- Gcc spits out warnings about the missing newlines at the end of files.

Markus

Preliminary CD-Rom support on MacOS X #5 (take 2)

[emmanuel maillard]

Hi,

Le 30 déc. 05 à 01:39, Markus Amsler a écrit :
> Hi,
>
> I took a look at your patches, here's what i've found:
>
> ntdll_cdrom.diff:
> > #
> >
> > @ cdecl MODULE_DllThreadAttach(ptr)
> > @ cdecl MODULE_GetLoadOrderW(ptr wstr wstr)
> > +@ cdecl CDROM_InitCDDevices()
> > +@ cdecl CDROM_FoundDevices()
> > +@ cdecl CDROM_BSDPathForMedia(ptr)
> > +@ cdecl CDROM_GetMountPointForBSDDevice(ptr)
> > +@ cdecl CDROM_BSDPathForHandle(long)
> > \ No newline at end of file
>
> - You shouldn't add more seperation hacks. Besides that, if _APPLE_  
> is not defined, the linker doesn't find these symbols.

I tried to reduce them to the maximum. Sorry about that i correct it  
to the attached patch.
> - Gcc spits out warnings about the missing newlines at the end of  
> files.
>
> Markus

Thanks

Emmanuel

Changelog:
	ntdll/cdrom.c, ntdll.spec :
	- preliminary CD-Rom support on Darwin