Re: d3d9/tests: Limit the back buffer to 800x600 in the scissor size test.
On Thu, 12 Mar 2009, Michael Stefaniuc wrote:
Most netbooks have only a 1024x600 display size and a 1024x768 back buffer fails on those. See http://test.winehq.org/data/ae1802d01ba2ec12a51ffb450dc7810d03809fe9/wine_ms...
Maybe the test should check the screen size and skip the test if it is too small... (as a preventive mesure in case a PC has an even smaller screen) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.
Francois Gouget wrote:
On Thu, 12 Mar 2009, Michael Stefaniuc wrote:
Most netbooks have only a 1024x600 display size and a 1024x768 back buffer fails on those. See http://test.winehq.org/data/ae1802d01ba2ec12a51ffb450dc7810d03809fe9/wine_ms...
Maybe the test should check the screen size and skip the test if it is too small... (as a preventive mesure in case a PC has an even smaller screen) I sent the patch out to provoke a better patch from somebody more knowledgeable in that domain. Of course only if it's worth the effort; until the advent of the netbooks with their odd screen size assuming that 1024x768 will just work was good enough.
bye michael
2009/3/12 Michael Stefaniuc <mstefani(a)redhat.com>:
I sent the patch out to provoke a better patch from somebody more knowledgeable in that domain. Of course only if it's worth the effort; until the advent of the netbooks with their odd screen size assuming that 1024x768 will just work was good enough.
My EeePC only does 800x640. IIRC test_reset() is affected by a similar problem, in that it assumes 800x600 is available. I can probably write a patch that just uses two different screen sizes from the list of available ones.
Henri Verbeet schrieb:
2009/3/12 Michael Stefaniuc <mstefani(a)redhat.com>:
I sent the patch out to provoke a better patch from somebody more knowledgeable in that domain. Of course only if it's worth the effort; until the advent of the netbooks with their odd screen size assuming that 1024x768 will just work was good enough.
My EeePC only does 800x640. IIRC test_reset() is affected by a similar problem, in that it assumes 800x600 is available. I can probably write a patch that just uses two different screen sizes from the list of available ones.
The resolution was a known problem when I made the test, but which resolution would be the best? Is there a solution which fits all platforms? Probably we should only skip the full screen tests, on machines which doesn't support such a resolution, which I guess were failing? Probably next time someone is trying to run wine on his mobile phone with a resolution like 128x160 ... Cheers Rico
participants (4)
-
Francois Gouget -
Henri Verbeet -
Michael Stefaniuc -
Rico Schüller