Re: [PATCH 1/2] riched20: Implement ITextRange::GetChar.

[Alexandre Julliard]

Jactry Zeng <wine(a)jactry.com> writes:
> +#define TEST_TXTRGE_GETCHAR(first, lim, expected_char)                  \
> +  create_interfaces(&w, &reOle, &txtDoc, NULL);                         \
> +  SendMessageA(w, WM_SETTEXT, 0, (LPARAM)test_text1);                   \
> +  ITextDocument_Range(txtDoc, first, lim, &txtRge);                     \
> +  pch = 0xdeadbeef;                                                     \
> +  hres = ITextRange_GetChar(txtRge, &pch);                              \
> +  ok(hres == S_OK, "ITextRange_GetChar\n");                             \
> +  ok(pch == expected_char, "got wrong char: %c\n", pch);                \
> +  ITextRange_Release(txtRge);                                           \
> +  release_interfaces(&w, &reOle, &txtDoc, NULL);

Please avoid that sort of huge macro. If necessary, use helper functions
instead.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/2] riched20: Implement ITextRange::GetChar.

[Jactry Zeng]

Hi Julliard,
2014-09-15 22:44 GMT+08:00 Alexandre Julliard <julliard(a)winehq.org>:
> Please avoid that sort of huge macro. If necessary, use helper functions
> instead.

Thanks for your review!
A newer version was sent.

-- 
Regards,
Jactry Zeng