[PATCH] amstream/tests: Add return value checks (Coverity).
Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- For consistency with other tests. dlls/amstream/tests/amstream.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c index da5ef8f56a1..b12c205db55 100644 --- a/dlls/amstream/tests/amstream.c +++ b/dlls/amstream/tests/amstream.c @@ -496,7 +496,8 @@ static void test_openfile(const WCHAR *test_avi_path) ok(hr == S_OK, "Got hr %#x.\n", hr); clock = NULL; - IMediaFilter_GetSyncSource(media_filter, &clock); + hr = IMediaFilter_GetSyncSource(media_filter, &clock); + ok(hr == S_OK, "Got hr %#x.\n", hr); ok(!!clock, "Expected non-NULL clock.\n"); hr = IAMMultiMediaStream_SetState(mmstream, STREAMSTATE_STOP); @@ -551,7 +552,8 @@ static void test_openfile(const WCHAR *test_avi_path) ok(hr == S_OK, "Got hr %#x.\n", hr); clock = (IReferenceClock *)0xdeadbeef; - IMediaFilter_GetSyncSource(media_filter, &clock); + hr = IMediaFilter_GetSyncSource(media_filter, &clock); + ok(hr == S_OK, "Got hr %#x.\n", hr); ok(!clock, "Got clock %p.\n", clock); hr = IAMMultiMediaStream_SetState(mmstream, STREAMSTATE_STOP); -- 2.28.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=81610 Your paranoid android. === w2008s64 (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w8 (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w8adm (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64 (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_2scr (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_ar (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_he (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_ja (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_zh_CN (32 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w2008s64 (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w864 (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64 (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_2scr (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_ar (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_he (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_ja (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1. === w10pro64_zh_CN (64 bit report) === amstream: amstream.c:556: Test failed: Got hr 0x1.
participants (2)
-
Marvin -
Nikolay Sivov