Re: cmd: add support for todo_wine constructions in testing infrastructure
Hi Frédéric, On 06/12/11 23:01, Frédéric Delanoy wrote:
- + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl); +
There is no need to add such logic directly to test_output, this can be returned from comare_line. Jacek
On Mon, Jun 13, 2011 at 13:48, Jacek Caban <jacek(a)codeweavers.com> wrote:
Hi Frédéric,
On 06/12/11 23:01, Frédéric Delanoy wrote:
- + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl); +
There is no need to add such logic directly to test_output, this can be returned from comare_line.
Do you mean as an extra parameter to compare_line? e.g. static const char *compare_line(const char *out_line, const char *out_end, const char *exp_line, const char *exp_end) becoming static const char *compare_line(const char *out_line, const char *out_end, const char *exp_line, const char *exp_end, BOOL* is_todo_line)
On 06/13/11 14:02, Frédéric Delanoy wrote:
On Mon, Jun 13, 2011 at 13:48, Jacek Caban <jacek(a)codeweavers.com> wrote:
Hi Frédéric,
On 06/12/11 23:01, Frédéric Delanoy wrote:
- + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl); + There is no need to add such logic directly to test_output, this can be returned from comare_line. Do you mean as an extra parameter to compare_line? e.g.
static const char *compare_line(const char *out_line, const char *out_end, const char *exp_line, const char *exp_end)
becoming
static const char *compare_line(const char *out_line, const char *out_end, const char *exp_line, const char *exp_end, BOOL* is_todo_line)
Yes, something like that. Jacek
participants (2)
-
Frédéric Delanoy -
Jacek Caban