Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> +    else if (ptr->builtin_type != -1)
> +    {
> +        const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type];
> +        ret = min( count, classname->len ) - 1;
> +        memcpy( buffer, classname->nameA, ret );
> +        buffer[ret] = 0;
> +    }

In case of count = 0 this code will overwrite random data.

-- 
Dmitry.

[PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

[Nikolay Sivov]

On 2/18/2014 11:42, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > +    else if (ptr->builtin_type != -1)
> > +    {
> > +        const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type];
> > +        ret = min( count, classname->len ) - 1;
> > +        memcpy( buffer, classname->nameA, ret );
> > +        buffer[ret] = 0;
> > +    }
> > In case of count = 0 this code will overwrite random data.

No, it won't.