Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

[Alexandre Julliard]

Bruno Jesus <00cpxxx(a)gmail.com> writes:
> +/* Max ATR size defined by ISO-7816 */
> +#define MAX_ATR_SIZE 33

I don't see that one in my PSDK, where does it come from?

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/2] include: Add a few defines to winscard.h (try 2)

[Bruno Jesus]

On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > +/* Max ATR size defined by ISO-7816 */
> > +#define MAX_ATR_SIZE 33
>
> I don't see that one in my PSDK, where does it come from?

My bad, apologies. I copied it from Vincent Hardy patch series but in
fact the variable should be name SCARD_ATR_LENGTH and should be in
winsmcrd.h. I'm still not using these defines yet so if possible I
would like the [2/2] to be commited if no mistakes are found in it,
I'll resend this one later.

Best wishes,
Bruno

[PATCH 1/2] include: Add a few defines to winscard.h (try 2)

[André Hentschel]

Am 28.10.2011 19:42, schrieb Bruno Jesus:
> On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > > +/* Max ATR size defined by ISO-7816 */
> > > +#define MAX_ATR_SIZE 33
> >
> > I don't see that one in my PSDK, where does it come from?
>
> My bad, apologies. I copied it from Vincent Hardy patch series but in
> fact the variable should be name SCARD_ATR_LENGTH and should be in
> winsmcrd.h. I'm still not using these defines yet so if possible I
> would like the [2/2] to be commited if no mistakes are found in it,

btw: if there is no dependencies than you don't need numbered patchsets


-- 

Best Regards, André Hentschel

[PATCH 1/2] include: Add a few defines to winscard.h (try 2)

[Bruno Jesus]

2011/10/28 André Hentschel <nerv(a)dawncrow.de>:
> Am 28.10.2011 19:42, schrieb Bruno Jesus:
> ...
> btw: if there is no dependencies than you don't need numbered patchsets

Agreed. Sorry again.

Best wishes,
Bruno