Re: [PATCH] qedit: List parameters in order in create function traces.

[Andrew Eikum]

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com>

Thanks. Just for my own information, are you working in this area? I'm
working on video embedding in Office 2010 (Bug 40179) at the moment.

Andrew

On Fri, Apr 22, 2016 at 12:18:00AM -0600, Alex Henrie wrote:
> Cc: Andrew Eikum <aeikum(a)codeweavers.com>
>
> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
> ---
>  dlls/qedit/mediadet.c      | 2 +-
>  dlls/qedit/samplegrabber.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
> index 9098223..53ab75a 100644
> --- a/dlls/qedit/mediadet.c
> +++ b/dlls/qedit/mediadet.c
> @@ -640,7 +640,7 @@ static const IMediaDetVtbl IMediaDet_VTable =
>  HRESULT MediaDet_create(IUnknown * pUnkOuter, LPVOID * ppv) {
>      MediaDetImpl* obj = NULL;
>
> -    TRACE("(%p,%p)\n", ppv, pUnkOuter);
> +    TRACE("(%p,%p)\n", pUnkOuter, ppv);
>
> obj = CoTaskMemAlloc(sizeof(MediaDetImpl));
>      if (NULL == obj) {
> diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c
> index e9e4906..946dba9 100644
> --- a/dlls/qedit/samplegrabber.c
> +++ b/dlls/qedit/samplegrabber.c
> @@ -1262,7 +1262,7 @@ HRESULT SampleGrabber_create(IUnknown *pUnkOuter, LPVOID *ppv)
>      ISeekingPassThru *passthru;
>      HRESULT hr;
>
> -    TRACE("(%p,%p)\n", ppv, pUnkOuter);
> +    TRACE("(%p,%p)\n", pUnkOuter, ppv);
>
> obj = CoTaskMemAlloc(sizeof(SG_Impl));
>      if (NULL == obj) {
> -- 
> 2.8.0

[PATCH] qedit: List parameters in order in create function traces.

[Alex Henrie]

2016-04-22 6:17 GMT-06:00 Andrew Eikum <aeikum(a)codeweavers.com>:
> Thanks. Just for my own information, are you working in this area? I'm
> working on video embedding in Office 2010 (Bug 40179) at the moment.

I've been trying to fix bug 32473. I actually had a question for you,
but I'll send it as a separate email because it's not related to this
patch.

-Alex