Finding patches in wine-cvs mailing list for regression tests using CVS dates
Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place. I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.org/site/docs/winedev-guide/x1344, but I think it's outdated. The wine-cvs archive mailing list linked in the documentation is http://www.winehq.org/hypermail/wine-cvs This archive ends in August 2005. I think the archive linked should be http://www.winehq.org/pipermail/wine-cvs/ But the main problem comes now. I used CVS to make the regression test. But when looking in the mailing list messages, the date in them isn't the CVS commit date. Instead, it is the Git commit date (or at least I think so). The Git to CVS gateway seems to get some time to commit the changes to the CVS. So I don't know how can I get the exact patch that caused the problem. I'll try to explain it with my problem. When I update the CVS to "2005-12-21 21:29:02 +0100", the game runs perfectly. However, if I update the CVS to "2005-12-21 21:29:03 +0100", it crashes. However, looking in the mailing list, there are no commits at "2005-12-21 21:29:03 +0100" (the previous was made at "2005-12-21 21:19:47 +0100"). Is there something I'm missing? How could I proceed? Thanks. P.D: I didn't give more information about the crash because the message was mainly focused to the dates in the mailing list question. Of course, I'll fill a bug report when I find the patch that caused the problem.
On Sat, Dec 31, 2005 at 01:45:04PM +0100, Daniel Calviño Sánchez wrote:
Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place.
I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.org/site/docs/winedev-guide/x1344, but I think it's outdated.
The wine-cvs archive mailing list linked in the documentation is http://www.winehq.org/hypermail/wine-cvs This archive ends in August 2005.
I think the archive linked should be http://www.winehq.org/pipermail/wine-cvs/
But the main problem comes now. I used CVS to make the regression test. But when looking in the mailing list messages, the date in them isn't the CVS commit date. Instead, it is the Git commit date (or at least I think so). The Git to CVS gateway seems to get some time to commit the changes to the CVS.
So I don't know how can I get the exact patch that caused the problem.
I'll try to explain it with my problem. When I update the CVS to "2005-12-21 21:29:02 +0100", the game runs perfectly. However, if I update the CVS to "2005-12-21 21:29:03 +0100", it crashes. However, looking in the mailing list, there are no commits at "2005-12-21 21:29:03 +0100" (the previous was made at "2005-12-21 21:19:47 +0100").
Is there something I'm missing? How could I proceed? Thanks.
There is a CVS commit that has: revision 1.24 date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 Marcus Meissner <marcus(a)jet.franken.de> msvcrt: Implemented wctime(), wasctime(). Free thread data in DLL_THREAD_DETACH. So you are looking for this: http://www.winehq.org/pipermail/wine-cvs/2005-December/019937.html http://source.winehq.org/git/?p=wine.git;a=commit;h=9a583763eefb7cec46e0b4b0... (1 hour before approximately) Its likely that there is a delay between the GIT commit and the CVS integration. Ciao, Marcus
2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>:
There is a CVS commit that has: revision 1.24 date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 Marcus Meissner <marcus(a)jet.franken.de> msvcrt: Implemented wctime(), wasctime(). Free thread data in DLL_THREAD_DETACH.
But, where can the information about CVS commits be seen? Perhaps I sound somewhat silly... but I can't find it. I mean, I know where I can see the changes made to a specific file. But I don't know where can I see a list with all the changes made in the CVS or something like that (I think you didn't get the information about this CVS commit looking every file in the CVS :) )
So you are looking for this: http://www.winehq.org/pipermail/wine-cvs/2005-December/019937.html http://source.winehq.org/git/?p=wine.git;a=commit;h=9a583763eefb7cec46e0b4b0... (1 hour before approximately)
Its likely that there is a delay between the GIT commit and the CVS integration.
Ciao, Marcus
Thanks a lot, this is the patch I was looking for. I'm going to fill a bug report now.
On 12/31/05, Daniel Calviño Sánchez <danxuliu(a)gmail.com> wrote:
But, where can the information about CVS commits be seen? Perhaps I sound somewhat silly... but I can't find it. I mean, I know where I can see the changes made to a specific file. But I don't know where can I see a list with all the changes made in the CVS or something like that (I think you didn't get the information about this CVS commit looking every file in the CVS :) )
cvs.winehq.org/cvsweb/wine -- James Hawkins
On Sat, Dec 31, 2005 at 03:48:16PM +0100, Daniel Calviño Sánchez wrote:
2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>:
There is a CVS commit that has: revision 1.24 date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 Marcus Meissner <marcus(a)jet.franken.de> msvcrt: Implemented wctime(), wasctime(). Free thread data in DLL_THREAD_DETACH.
But, where can the information about CVS commits be seen? Perhaps I sound somewhat silly... but I can't find it. I mean, I know where I can see the changes made to a specific file. But I don't know where can I see a list with all the changes made in the CVS or something like that (I think you didn't get the information about this CVS commit looking every file in the CVS :) )
log for a file: cvs log file.c to see diff between dates: cvs diff -u -D "time1" -D "time2"
Thanks a lot, this is the patch I was looking for. I'm going to fill a bug report now.
Its already fixed in current CVS... Ciao, Marcus
2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>:
Thanks a lot, this is the patch I was looking for. I'm going to fill a bug report now.
Its already fixed in current CVS...
I have just seen the fix. I tested with an updated CVS and it works fine again. Thanks for the help, and sorry for wasting your time :$
participants (3)
-
Daniel Calviño Sánchez -
James Hawkins -
Marcus Meissner