ddraw: Fix Setmaterial with a test

[David Adam]

> David Adam wrote:
> > * The test succeded in my windows XP box.
> > *>>*
> > *>You have only ddraw test and no d3d test.
>
> Vitaliy.

Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes.
It is a forbidden value (see bug 13646). So, no test can be performed
for d3d8 and d3d9.

I sent a patch to removed these test earlier.

David

[Vitaliy Margolen]

David Adam wrote:
> > David Adam wrote:
> > > / The test succeded in my windows XP box.
> > > />>/ 
> > > />You have only ddraw test and no d3d test.
> >
> > Vitaliy.
>
> Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes.
>
> It is a forbidden value (see bug 13646). So, no test can be performed for d3d8 and d3d9.
>
> I sent a patch to removed these test earlier.

So why are you adding the check that is not present on windows? What are th 
reasoning to have this if it clearly absent in native implementation?

Vitaliy.

[David Adam]

I sent a patch to removed these test earlier.
> > So why are you adding the check that is not present on windows? What are
> > th reasoning to have this if it clearly absent in native implementation?

That's why I removed it form wined3d. I set the check in ddraw, since only
ddraw checks it.

David

[Vitaliy Margolen]

David Adam wrote:
> I sent a patch to removed these test earlier.
>
> So why are you adding the check that is not present on windows? What
>     are th reasoning to have this if it clearly absent in native
>     implementation?
>
> That's why I removed it form wined3d. I set the check in ddraw, since 
> only ddraw checks it.
>
> David

Ok makes sense.

Vitaliy.

[Stefan Dösinger]

> So why are you adding the check that is not present on windows? What
> are th
> reasoning to have this if it clearly absent in native implementation?
> As I understand it, native ddraw.dll(d3d7) has the check, while d3d8/d3d9 do
> not. Thus he removed it from WineD3D to have the same behavior as native in
> d3d8 and d3d9, and added it to ddraw to check it there(as native does)

[David Adam]

Yes, it is exactly that. So, I wonder why the patches were not committed.

David

2008/6/11 Stefan Dösinger <stefandoesinger(a)gmx.at>:
> > So why are you adding the check that is not present on windows? What
> > are th
> > reasoning to have this if it clearly absent in native implementation?
> > As I understand it, native ddraw.dll(d3d7) has the check, while d3d8/d3d9
> > do
> > not. Thus he removed it from WineD3D to have the same behavior as native in
> > d3d8 and d3d9, and added it to ddraw to check it there(as native does)

[Stefan Dösinger]

Maybe you have to resubmit them after the discussion, or maybe Alexandre
didn't commit them due to the code freeze if they do not explicitly fix a
1.0.0 bug

 

From: David Adam [mailto:david.adam.cnrs(a)gmail.com] 
Sent: Saturday, June 14, 2008 12:00 PM
To: Stefan Dösinger
Cc: Vitaliy Margolen; wine-devel
Subject: Re: ddraw: Fix Setmaterial with a test

 

Yes, it is exactly that. So, I wonder why the patches were not committed.