Re: [PATCH] wininet: Resize buffer when call to InternetCanonicalizeUrlW fails in InternetCrackUrlW

[Sebastian Lackner]

On 13.11.2016 21:15, Marcus Meissner wrote:
> From: Michael Müller <michael(a)fds-team.de>
>
> Import from wine-staging
> Fixes wine bug 40598 in staging
>
> Signed-off-by: Michael Mueller <michael(a)fds-team.de>
> Signed-off-by: Marcus Meissner <meissner(a)suse.de>

If the patch submission rules have not been changed at this WineConf, it is still not
allowed to add Signed-off-by lines for other people.

Also, the patch is most likely not the right way to fix it, as I already pointed out
in https://www.winehq.org/pipermail/wine-patches/2016-July/152110.html:

""" Reason for the failure is because after decoding a "/" is added, and it
does not fit into the buffer anymore. Michael wrote a patch to dynamically
allocate a buffer, however I do not think the "/" should be added in the
first place. """

Regards,
Sebastian

[PATCH] wininet: Resize buffer when call to InternetCanonicalizeUrlW fails in InternetCrackUrlW

[Matteo Bruni]

2016-11-14 7:55 GMT-06:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> On 13.11.2016 21:15, Marcus Meissner wrote:
> > From: Michael Müller <michael(a)fds-team.de>
> >
> > Import from wine-staging
> > Fixes wine bug 40598 in staging
> >
> > Signed-off-by: Michael Mueller <michael(a)fds-team.de>
> > Signed-off-by: Marcus Meissner <meissner(a)suse.de>
>
> If the patch submission rules have not been changed at this WineConf, it is still not
> allowed to add Signed-off-by lines for other people.

No, they haven't changed. There has been some clarification around
sending patches from someone else: if a patch has been significantly
reworked, it's better to drop the signed-off from the original author.

[PATCH] wininet: Resize buffer when call to InternetCanonicalizeUrlW fails in InternetCrackUrlW

[Marcus Meissner]

On Wed, Nov 16, 2016 at 11:19:45AM -0600, Matteo Bruni wrote:
> 2016-11-14 7:55 GMT-06:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> > On 13.11.2016 21:15, Marcus Meissner wrote:
> > > From: Michael Müller <michael(a)fds-team.de>
> > >
> > > Import from wine-staging
> > > Fixes wine bug 40598 in staging
> > >
> > > Signed-off-by: Michael Mueller <michael(a)fds-team.de>
> > > Signed-off-by: Marcus Meissner <meissner(a)suse.de>
> >
> > If the patch submission rules have not been changed at this WineConf, it is still not
> > allowed to add Signed-off-by lines for other people.
>
> No, they haven't changed. There has been some clarification around
> sending patches from someone else: if a patch has been significantly
> reworked, it's better to drop the signed-off from the original author.

Correct. I was just not correct in submitting it like this.

Ciao, Marcus