Re: [PATCH] d3dx9_36: Implement ID3DXEffect_FindNextValidTechnique + add tests.

[Rico Schüller]

On 02.08.2013 00:03, Christian Costa wrote:
> +    technique = (D3DXHANDLE)0xdeadbeef;
> +    hr = effect->lpVtbl->FindNextValidTechnique(effect, technique1, &technique);
> +    ok(hr == D3D_OK, "FindNextValidTechnique failed, got %#x, expected %#x\n", hr, D3D_OK);
> +    ok(technique == technique2, "Technique returned %p, expected %p\n", technique, technique2);
> +
> +    technique = (D3DXHANDLE)0xdeadbeef;
> +    hr = effect->lpVtbl->FindNextValidTechnique(effect, technique2, &technique);
> +    ok(hr == S_FALSE, "FindNextValidTechnique, got %#x, expected %#x\n", hr, S_FALSE);

Looks fine to me, but I found one minor issue. I'd write 
"FindNextValidTechnique failed, ..." as in the line above.

Cheers
Rico