[PATCH] nsiproxy: Fix use after free in icmp_send_echo (scan-build)

21 Dec 2021

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
---
 dlls/nsiproxy.sys/icmp_echo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/nsiproxy.sys/icmp_echo.c b/dlls/nsiproxy.sys/icmp_echo.c
index cfebb287547..f36ff156bef 100644
--- a/dlls/nsiproxy.sys/icmp_echo.c
+++ b/dlls/nsiproxy.sys/icmp_echo.c
@@ -656,8 +656,8 @@ NTSTATUS icmp_send_echo( void *args )
     if (ret < 0)
     {
         TRACE( "sendto() rets %d errno %d\n", ret, errno );
-        icmp_data_free( data );
         params->reply_len = data->ops->set_reply_ip_status( errno_to_ip_status( errno ), params->bits, params->reply );
+        icmp_data_free( data );
         return STATUS_SUCCESS;
     }
 
-- 
2.34.1

    

Alex Henrie