Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

[Paul Vriens]

Jeff Latimer wrote:
> Note that Inet_Ntop is only available in Vista and Windows 2008.  This 
> patch removes the version testing.  This one removes the redundant test 
> after GetModuleHandle and adds win_skip().
> ---
>  dlls/ws2_32/tests/sock.c |   68 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 68 insertions(+), 0 deletions(-)
>
> ------------------------------------------------------------------------

Hi,

There is no need to have two if (pInetNtop) statements right after each other, 
this could be just one.

Maybe it's even better that before you start using pInetNtop, you do:

if (!pInetNtop)
{
     win_skip("InetNtop not present, not executing tests\n");
     return;
}

You than don't need to indent the code anymore.

-- 
Cheers,

Paul.

[2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

[Jeff Latimer]

Paul Vriens wrote:
> Hi,
>
> There is no need to have two if (pInetNtop) statements right after 
> each other, this could be just one.
>
> You than don't need to indent the code anymore.
> You are right.  I tidied up the code organising in IPV4 and IPV6 and did 
> not notice I had removed the code between the two if tests.