Re: [PATCH] d3dx9: Don't complain when overwriting effect object id 0.

[Matteo Bruni]

2016-04-18 15:26 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
> Matteo,
>
> I must be missing something, but don't you forget to free the
> object->data when it is reallocated at least for object id 0 when it is
> not FIXME anymore? I suppose you don't but I looked through several
> times and do not see how it can be freed when it was allocated previously.
>
> Regards,
>     Paul.

No, you're right, I forgot the free altogether. Let's drop this patch,
unless it's too late. I'll send a fix either way.

[PATCH] d3dx9: Don't complain when overwriting effect object id 0.

[Matteo Bruni]

2016-04-18 17:42 GMT+02:00 Matteo Bruni <matteo.mystral(a)gmail.com>:
> 2016-04-18 15:26 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
> > Matteo,
> >
> > I must be missing something, but don't you forget to free the
> > object->data when it is reallocated at least for object id 0 when it is
> > not FIXME anymore? I suppose you don't but I looked through several
> > times and do not see how it can be freed when it was allocated previously.
> >
> > Regards,
> >     Paul.
>
> No, you're right, I forgot the free altogether. Let's drop this patch,
> unless it's too late. I'll send a fix either way.

For the records, the leak is already there in git. It makes sense to
fix it in this patch though.

[PATCH] d3dx9: Don't complain when overwriting effect object id 0.

[Matteo Bruni]

> > No, you're right, I forgot the free altogether. Let's drop this patch,
> > unless it's too late. I'll send a fix either way.

Uh, somehow I missed the earlier push. Sending the additional patch...