Re: [3/6] windowscodecs: Implement tiff encoder options (TiffCompressionMethod and CompressionQuality)

[Dmitry Timoshkov]

Ludger Sprenker <ludger(a)sprenker.net> wrote:
> +        read_hr = IPropertyBag2_Read(pIEncoderOptions, 2, pb, NULL, v, hr);
> +        if (SUCCEEDED(hr))

Looks like a typo.

-- 
Dmitry.

[3/6] windowscodecs: Implement tiff encoder options (TiffCompressionMethod and CompressionQuality)

[Ludger Sprenker]

Am Sonntag, 20. Januar 2013, 12:53:56 schrieb Dmitry Timoshkov:
> Ludger Sprenker <ludger(a)sprenker.net> wrote:
> > +        read_hr = IPropertyBag2_Read(pIEncoderOptions, 2, pb, NULL, v,
> > hr); +        if (SUCCEEDED(hr))
>
> Looks like a typo.

Yes, it is typo. I am checking SUCCEEDED(read_hr) in the jpeg and png encoder. 

I will create a new patch set only for the PropertyBag class (based on the 
suggestions from Vincent). After these changes are in the master branch I will 
resubmit the encoder patches.