[PATCH] shell32: Remove redundant not-NULL check (coccinellery)

[Michael Stefaniuc]

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
---
return E_OUTOFMEMORY if list is NULL.

 dlls/shell32/recyclebin.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c
index 0d80e6376d..49e7f5da32 100644
--- a/dlls/shell32/recyclebin.c
+++ b/dlls/shell32/recyclebin.c
@@ -431,8 +431,7 @@ static HRESULT WINAPI RecycleBin_EnumObjects(IShellFolder2 *iface, HWND hwnd, SH
     return S_OK;
 
 failed:
-    if (list)
-        IEnumIDList_Release(&list->IEnumIDList_iface);
+    IEnumIDList_Release(&list->IEnumIDList_iface);
     for (; i<pidls_count; i++)
         ILFree(pidls[i]);
     SHFree(pidls);
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=49024

Your paranoid android.


=== debian9 (32 bit report) ===

shell32:
progman_dde.c:249: Test failed: expected DMLERR_NO_ERROR, got 16393
progman_dde.c:250: Test failed: directory should not exist