Re: [PATCH] mountmgr: Add and remove drives when they are (un)mounted.

[Vitaliy Margolen]

Lei Zhang wrote:
> Hi,
>
> It looks like mountmgr.sys does not remove drives when devices are
> unmounted. We should look at the is_mounted property and take the
> appropriate action when it changes.

This is going the wrong way. Wine already can't deal with blank media
without some "hackish" workarounds. With this patch you will break even that.

Wine should keep drive visible for applications even if there is not media
or a blank media inserted.

Vitaliy.

[PATCH] mountmgr: Add and remove drives when they are (un)mounted.

[Lei Zhang]

On Sun, Nov 2, 2008 at 7:54 AM, Vitaliy Margolen
<wine-devel(a)kievinfo.com> wrote:
> Lei Zhang wrote:
> > Hi,
> >
> > It looks like mountmgr.sys does not remove drives when devices are
> > unmounted. We should look at the is_mounted property and take the
> > appropriate action when it changes.
>
> This is going the wrong way. Wine already can't deal with blank media
> without some "hackish" workarounds. With this patch you will break even that.
>
> Wine should keep drive visible for applications even if there is not media
> or a blank media inserted.
>
> Vitaliy.

How about leaving cdrom / floppies alone and only add/remove disks on
(un)mount. Currently , if we add a disk, and then unmount, but not
remove it, the disk end up in a state where it's still there, but all
of its contents are gone.