Re: d3d8: Fix incorrect ordering of brackets in IDirect3DVertexShader8Impl_GetDevice.
30 Sep
2008
30 Sep
'08
1:30 p.m.
2008/9/30 Rob Shearman <robertshearman(a)gmail.com>:
The comparison should be (D3D_OK == hr && myDevice), not (D3D_OK == (hr && myDevice)).
d3d8 and d3d9 are pretty bad at stuff like this, unfortunately. Strictly speaking we should also compare to WINED3D_OK instead of D3D_OK here, but they have the same values.
30 Sep
30 Sep
3 p.m.
New subject: d3d8: Fix incorrect ordering of brackets in IDirect3DVertexShader8Impl_GetDevice.
2008/9/30 Henri Verbeet <hverbeet(a)gmail.com>:
2008/9/30 Rob Shearman <robertshearman(a)gmail.com>:
The comparison should be (D3D_OK == hr && myDevice), not (D3D_OK == (hr && myDevice)).
d3d8 and d3d9 are pretty bad at stuff like this, unfortunately. Strictly speaking we should also compare to WINED3D_OK instead of D3D_OK here, but they have the same values.
Ok, I will fix that in my patches and resend. -- Rob Shearman
6283
Age (days ago)
6283
Last active (days ago)
1 comments
2 participants
participants (2)
-
Henri Verbeet -
Rob Shearman