[PATCH v5 2/2] user32:Fix z order error when WS_CHILD window want to be topmost windows.
window with WS_CHILD does not need to change Z order when SetWindowPos param hwndInsertAfter is HWND_TOPMOST or HWND_NOTOPMOST. Solve the problems mentioned in the previous patch, and Remove todo_wine on test_child_topmost_zorder. v2： Add git log information v3: Move the path to fixup_flags function, only used to fix SetWindowPos function problem. v4: Divide a path into two pathes, better explain the prolem. and add notopmost verification v5: Add todo_wine to test patch[patch v5 1/2], and optimize fixup_flags[patch v5 2/2]. Signed-off-by: cuijiajin <cuijiajin(a)uniontech.com>
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=73852 Your paranoid android. === w1064v1507 (32 bit report) === user32: win.c:9535: Test failed: Timed out waiting for the child process === w1064v1809 (32 bit report) === user32: win.c:3221: Test failed: GetActiveWindow() = 0003005A win.c:3224: Test failed: GetFocus() = 00000000 win.c:3236: Test failed: GetFocus() = 00000000 win.c:3239: Test failed: GetFocus() = 00000000 win.c:3242: Test failed: GetFocus() = 00000000 win.c:3245: Test failed: GetActiveWindow() = 0003005A win.c:3249: Test failed: GetFocus() = 00000000 win.c:3252: Test failed: GetFocus() = 00000000 win.c:3946: Test failed: hwnd 00020174/001702C8 message 0737 win.c:3951: Test failed: hwnd 001702C8/001702C8 message 0202 win.c:3956: Test failed: hwnd 001702C8/001702C8 message 0203 win.c:3960: Test failed: message 0202 available === w1064v1809_2scr (32 bit report) === user32: win.c:3221: Test failed: GetActiveWindow() = 0004026A win.c:3224: Test failed: GetFocus() = 00000000 win.c:3236: Test failed: GetFocus() = 00000000 win.c:3239: Test failed: GetFocus() = 00000000 win.c:3242: Test failed: GetFocus() = 00000000 win.c:3245: Test failed: GetActiveWindow() = 0004026A win.c:3249: Test failed: GetFocus() = 00000000 win.c:3252: Test failed: GetFocus() = 00000000 win.c:3946: Test failed: hwnd 000301A0/000C031A message 0737 win.c:3951: Test failed: hwnd 000C031A/000C031A message 0202 win.c:3956: Test failed: hwnd 000C031A/000C031A message 0203 win.c:3960: Test failed: message 0202 available === w1064v1809_ar (32 bit report) === user32: win.c:9535: Test failed: Timed out waiting for the child process === w1064v1809_he (32 bit report) === user32: win.c:3781: Test failed: message 0738 available === w1064v1809_ja (32 bit report) === user32: win.c:3906: Test failed: hwnd 000202FE message 7fff win.c:3985: Test failed: hwnd 000202FE/00310074 message 7fff win.c:3988: Test failed: hwnd 000202FE/00310074 message 7fff === w1064v1809_zh_CN (32 bit report) === user32: win.c:3906: Test failed: hwnd 00010382 message 0282 win.c:3985: Test failed: hwnd 00010382/000B03CC message 0282 win.c:3988: Test failed: hwnd 00010382/000B03CC message 0282 === w1064v1809 (64 bit report) === user32: win.c:3221: Test failed: GetActiveWindow() = 0000000000030296 win.c:3224: Test failed: GetFocus() = 0000000000000000 win.c:3236: Test failed: GetFocus() = 0000000000000000 win.c:3239: Test failed: GetFocus() = 0000000000000000 win.c:3242: Test failed: GetFocus() = 0000000000000000 win.c:3245: Test failed: GetActiveWindow() = 0000000000030296 win.c:3249: Test failed: GetFocus() = 0000000000000000 win.c:3252: Test failed: GetFocus() = 0000000000000000 win.c:3946: Test failed: hwnd 00000000000200E4/00000000001502C8 message 0737 win.c:3951: Test failed: hwnd 00000000001502C8/00000000001502C8 message 0202 win.c:3956: Test failed: hwnd 00000000001502C8/00000000001502C8 message 0203 win.c:3960: Test failed: message 0202 available === debiant (32 bit report) === user32: combo.c:698: Test failed: 00000002: got 00000080 combo.c:704: Test failed: 00000002: got 00000080 combo.c:698: Test failed: 00000003: got 00000080 combo.c:704: Test failed: 00000003: got 00000080 === debiant (32 bit Japanese:Japan report) === user32: win.c:10204: Test failed: GetActiveWindow() = 00000000 win.c:10204: Test failed: GetFocus() = 00000000 win.c:10206: Test failed: Expected foreground window 0002003A, got 00E100A2 win.c:10209: Test failed: Received WM_ACTIVATEAPP(0), did not expect it. win.c:10216: Test failed: Expected foreground window 0002003A, got 00000000 win.c:10218: Test failed: GetActiveWindow() = 00000000 win.c:10218: Test failed: GetFocus() = 00000000 win.c:10226: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. === debiant (32 bit Chinese:China report) === user32: combo.c:698: Test failed: 00000002: got 00000080 combo.c:704: Test failed: 00000002: got 00000080 combo.c:698: Test failed: 00000003: got 00000080 combo.c:704: Test failed: 00000003: got 00000080 === debiant (32 bit WoW report) === user32: combo.c:698: Test failed: 00000002: got 00000080 combo.c:704: Test failed: 00000002: got 00000080 combo.c:698: Test failed: 00000003: got 00000080 combo.c:704: Test failed: 00000003: got 00000080 === debiant (64 bit WoW report) === user32: combo.c:698: Test failed: 00000002: got 00000080 combo.c:704: Test failed: 00000002: got 00000080 combo.c:698: Test failed: 00000003: got 00000080 combo.c:704: Test failed: 00000003: got 00000080
participants (2)
-
cuijiajin -
Marvin