Re: [PATCH 4/5] winex11: Release memory on xrandr cleanup.

[Alexandre Julliard]

Henri Verbeet <hverbeet(a)codeweavers.com> writes:
> diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c
> index 83137a4..a8dccd4 100644
> --- a/dlls/winex11.drv/xrandr.c
> +++ b/dlls/winex11.drv/xrandr.c
> @@ -289,6 +289,12 @@ done:
>      wine_tsx11_unlock();
>  }
>
> +void X11DRV_XRandR_Cleanup(void)
> +{
> +    HeapFree( GetProcessHeap(), 0, real_xrandr_rates_count );
> +    HeapFree( GetProcessHeap(), 0, real_xrandr_rates );
> +}

It's not worth adding complexity to free memory, in practice the
graphics driver is never going to be unloaded except at process exit.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 4/5] winex11: Release memory on xrandr cleanup.

[Henri Verbeet]

On 12 July 2012 18:46, Alexandre Julliard <julliard(a)winehq.org> wrote:
> It's not worth adding complexity to free memory, in practice the
> graphics driver is never going to be unloaded except at process exit.

I suppose, although I think in principle we'd also want to clean
things up when e.g. switching to virtual desktop mode. Either way,
winex11 isn't entirely consistent in this regard.