[PATCH] user32/tests: Remove a todo.

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
---
 dlls/user32/tests/msg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 6d0f0637ee..ef75d553b4 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -5142,7 +5142,7 @@ static void test_messages(void)
 
     ShowWindow(hwnd, SW_MINIMIZE);
     flush_events();
-    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
+    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
     flush_sequence();
 
     if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=52787

Your paranoid android.


=== wvistau64_zh_CN (32 bit report) ===

user32:
msg.c:5139: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088
msg.c:5152: Test failed: ShowWindow(SW_RESTORE):overlapped: 44: the msg sequence is not complete: expected 0000 - actual 0088
msg.c:11225: Test failed: WmDispatchPaint: 0: the msg sequence is not complete: expected 0085 - actual 0000

[Alexandre Julliard]

Zhiyi Zhang <zzhang(a)codeweavers.com> writes:
> @@ -5142,7 +5142,7 @@ static void test_messages(void)
>
> ShowWindow(hwnd, SW_MINIMIZE);
>      flush_events();
> -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);

It fails for me (obviously, otherwise it wouldn't be marked todo):

../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe msg && touch msg.ok
msg.c:5145: Test failed: ShowWindow(SW_SHOWMINIMIZED):overlapped: 52: the msg sequence is not complete: expected 0000 - actual 001f

-- 
Alexandre Julliard
julliard(a)winehq.org

[Zhiyi Zhang]

On 5/25/19 4:25 AM, Alexandre Julliard wrote:
> Zhiyi Zhang <zzhang(a)codeweavers.com> writes:
> > @@ -5142,7 +5142,7 @@ static void test_messages(void)
> >
> > ShowWindow(hwnd, SW_MINIMIZE);
> >      flush_events();
> > -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> > +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
> > It fails for me (obviously, otherwise it wouldn't be marked todo):
>
> ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe msg && touch msg.ok
> msg.c:5145: Test failed: ShowWindow(SW_SHOWMINIMIZED):overlapped: 52: the msg sequence is not complete: expected 0000 - actual 001f

Eh, sorry. It seems that its result is not consistent with different window managers.