Re: [PATCH 1/5] quartz: Add tests for Video Mixing Renderer 9
"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes:
From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Mon, 28 Jul 2008 18:18:06 -0700 Subject: [PATCH] quartz: Add tests for Video Mixing Renderer 9
--- dlls/quartz/tests/Makefile.in | 5 +- dlls/quartz/tests/null.h | 667 +++++++++++++++++++++++++++++
You should put that code in the C file, it doesn't belong in a header, especially since you are not using anywhere else. Building tests stand-alone is a nice to have, but it's not worth the cost of putting half the code in a header.
+#define trace_save trace + +/* Don't debug null by default */ +#define debug(...) do { } while (0)
Vararg macros are not portable. -- Alexandre Julliard julliard(a)winehq.org
Hi Alexandre, 2008/7/30 Alexandre Julliard <julliard(a)winehq.org>:
"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes:
From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Mon, 28 Jul 2008 18:18:06 -0700 Subject: [PATCH] quartz: Add tests for Video Mixing Renderer 9
--- dlls/quartz/tests/Makefile.in | 5 +- dlls/quartz/tests/null.h | 667 +++++++++++++++++++++++++++++
You should put that code in the C file, it doesn't belong in a header, especially since you are not using anywhere else. Building tests stand-alone is a nice to have, but it's not worth the cost of putting half the code in a header.
I want to re-use the code in the videorenderer test. I have some patches for that but they should be part of a different patchset. If I didn't want to do that I would have put it in vmr9.c, if you really want to I can duplicate the files.
+#define trace_save trace + +/* Don't debug null by default */ +#define debug(...) do { } while (0)
Vararg macros are not portable. Ok, I'll change it to (a, b) since there should not be any other arguments anyway.
Cheers, Maarten.
"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes:
I want to re-use the code in the videorenderer test. I have some patches for that but they should be part of a different patchset. If I didn't want to do that I would have put it in vmr9.c, if you really want to I can duplicate the files.
No, just put it in either vmr9.c or videorenderer.c and reference it from the other file. It means you have to link both of them together to build a stand-alone test, but that's ok. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Maarten Lankhorst