Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
17 Sep
2014
17 Sep
'14
8:27 a.m.
On Tue, Sep 16, 2014 at 06:39:32PM +0800, Jactry Zeng wrote:
+static HRESULT range_Collapse(LONG bStart, LONG *start, LONG *end) +{ + BOOL isdege = !(*end - *start);
This is a strange way to test for an equality! Also, isdegen or is_degen would be much better choices for the variable name. Huw.
17 Sep
17 Sep
8:37 a.m.
New subject: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
On Wed, Sep 17, 2014 at 09:27:18AM +0100, Huw Davies wrote:
On Tue, Sep 16, 2014 at 06:39:32PM +0800, Jactry Zeng wrote:
+static HRESULT range_Collapse(LONG bStart, LONG *start, LONG *end) +{ + BOOL isdege = !(*end - *start);
This is a strange way to test for an equality!
Also, isdegen or is_degen would be much better choices for the variable name.
Or even better, get rid of the variable completely if (*start == *end) return S_FALSE; Huw.
4194
Age (days ago)
4194
Last active (days ago)
1 comments
1 participants
participants (1)
-
Huw Davies