re: shell32: Test against the long form of the path.
This change http://source.winehq.org/git/wine.git/?a=commit;h=f2aa3259b913d75a273296f285... seems to causes a test failure on my wine box, but more importantly, on several windows boxes as well: http://test.winehq.org/data/200805221320/2000_aenglish-2k/shell32:shelllink.... http://test.winehq.org/data/200805221320/2003_jh-win2k3-vm/shell32:shelllink... http://test.winehq.org/data/200805221320/xp_om/shell32:shelllink.txt It passes on some systems, go figure: http://test.winehq.org/data/200805221320/xp_maarten-xp/shell32:shelllink.txt James, want to revert this one for now?
Dan Kegel wrote:
This change http://source.winehq.org/git/wine.git/?a=commit;h=f2aa3259b913d75a273296f285... seems to causes a test failure on my wine box, but more importantly, on several windows boxes as well:
http://test.winehq.org/data/200805221320/2000_aenglish-2k/shell32:shelllink.... http://test.winehq.org/data/200805221320/2003_jh-win2k3-vm/shell32:shelllink... http://test.winehq.org/data/200805221320/xp_om/shell32:shelllink.txt
It passes on some systems, go figure: http://test.winehq.org/data/200805221320/xp_maarten-xp/shell32:shelllink.txt
James, want to revert this one for now?
The commit was on the 26st and the links you show are from the 22nd ? -- Cheers, Paul.
On Tue, May 27, 2008 at 12:26 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
The commit was on the 26st and the links you show are from the 22nd ?
Gaaah. OK, I give up. I'm going back to bed, and I'm not coming out until I'm 27 again.
On Tue, May 27, 2008 at 1:56 PM, Dan Kegel <dank(a)kegel.com> wrote:
This change http://source.winehq.org/git/wine.git/?a=commit;h=f2aa3259b913d75a273296f285... seems to causes a test failure on my wine box, but more importantly, on several windows boxes as well:
http://test.winehq.org/data/200805221320/2000_aenglish-2k/shell32:shelllink.... http://test.winehq.org/data/200805221320/2003_jh-win2k3-vm/shell32:shelllink... http://test.winehq.org/data/200805221320/xp_om/shell32:shelllink.txt
It passes on some systems, go figure: http://test.winehq.org/data/200805221320/xp_maarten-xp/shell32:shelllink.txt
James, want to revert this one for now?
You're looking at the wrong test results. 20080522 (May 22) is before that patch was even committed. Check out the latest test results that have this commit: http://test.winehq.org/data/156dad05c08cd921288aedf1b281ff23844a1692/ All green except for Vista (which is a piece of trash, but still doesn't fail this test). -- James Hawkins
participants (3)
-
Dan Kegel -
James Hawkins -
Paul Vriens