Re: [PATCH 2/4] wined3d: Add support for the NULL format.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 24.01.2011 um 18:41 schrieb Henri Verbeet:
- if (surface) + if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment.
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNPqNaAAoJEN0/YqbEcdMwWFwP/0KW7THyiplBKi6csC7b6qWi i7Bi3VG5UMRomIDUyWMTlH+mwLqP7+AchzVYEHAM/blhe5yqemDc2YAN2f2/aNtV cbWoaIilTNF3PKH11wVvtUowidrwHmr9eV+SmHplvhdpJCTGKqU0ZxmNgl2DDiSD iPVfCmL6RE1e5n9i11AH7aQIcZjwPTEQBQlLR5IB1zpcnXab0r7vyTU44f0HkcJ0 785ast6QuG7lawibe7PmRz41VcFCtSMZF3QGgEujAn+frtYhqjVLdP8LITWZ+1mL jPfCWEQX1vlgbdMogykfnKSfm5oxaDMsrU3vMskwUGWFZCX+M7ffHIfy7cpy8HUt YVz4kqeaLr1xeZEsEaAQqjNal1PXoJCJSVA6ckV7VhB0+OkXpcH4i8ifdCtRv1PJ 0V/vryBBQgM9AczBQI8lb1c7w7lQL9EzttpNwbbC3mBTsT3/7EHJRuxR8EStIgzC 8gyTXveyBGuJel8Bwx6M+tBSskCNKFzPN7MKkvIE2+X5NSYj5eI05GSQRMl/eush jZWe+ls9GYgl76bL8+By1RRTsXGizPdW8UnX6HhzMfBErU1Z7IZbbqEiTMgXFOJL 0v0UXfLecE/mHlgrauk7b0C51JMtTXq5uuSOQ8uxFz/t2KcElja6pY4/nkN3DoLe I/cZaSyeQ3B5lTVTeZt/ =UA0G -----END PGP SIGNATURE-----
On 25 January 2011 11:17, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Am 24.01.2011 um 18:41 schrieb Henri Verbeet:
- if (surface) + if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment.
You're probably right, although it worked fine when I tested it, probably by chance. Please ignore this patch for now.
participants (2)
-
Henri Verbeet -
Stefan Dösinger