Re: [PATCH 2/2] dwrite: Free the mappings array, but not every element.

[Huw Davies]

On 2 Oct 2017, at 10:26, Huw Davies <huw(a)codeweavers.com> wrote:
> Signed-off-by: Huw Davies <huw(a)codeweavers.com>
> ---
> dlls/dwrite/analyzer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c
> index 6808b468d6..183abed7f9 100644
> --- a/dlls/dwrite/analyzer.c
> +++ b/dlls/dwrite/analyzer.c
> @@ -2305,8 +2305,8 @@ static ULONG WINAPI fontfallbackbuilder_Release(IDWriteFontFallbackBuilder *ifac
>                 IDWriteFontCollection_Release(mapping->collection);
>             heap_free(mapping->ranges);
>             heap_free(mapping->locale);
> -            heap_free(mapping);
>         }
> +        heap_free(fallbackbuilder->mappings);
>
> IDWriteFactory5_Release(fallbackbuilder->factory);
>         heap_free(fallbackbuilder);

Ah, this is a dup of 137464.

Huw.