Re: [PATCH] winspool.drv: Check return value of EnumPrintersA
On Sa, 2009-01-31 at 11:09 +0100, Marcus Meissner wrote:
- EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, &num); - if(needed) { + if (EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, &num) && needed) {
EnumPrinterA must always update "needed". "nedded" is 0, when EnumPrintersA failed or when no printer is installed. Line 1555 has similar code -- By by ... Detlef
On Sun, Feb 01, 2009 at 03:25:43PM +0100, Detlef Riekenberg wrote:
On Sa, 2009-01-31 at 11:09 +0100, Marcus Meissner wrote:
- EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, &num); - if(needed) { + if (EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, &num) && needed) {
EnumPrinterA must always update "needed". "nedded" is 0, when EnumPrintersA failed or when no printer is installed.
Line 1555 has similar code
Hmm, yes. I see the initialization in WINSPOOL_EnumPrinters() now. :) Ciao, Marcus
participants (2)
-
Detlef Riekenberg -
Marcus Meissner